linux-kernel - Re: [PATCH 4/4] usb: otg: twl4030-usb: Don't power down phy when it is in-use by charger.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120521221029.GB4346@andi>
Date:	Tue, 22 May 2012 00:10:29 +0200
From:	Andi Shyti <andi.shyti@...il.com>
To:	NeilBrown <neilb@...e.de>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, Felipe Balbi <balbi@...com>,
	Anton Vorontsov <cbou@...l.ru>,
	David Woodhouse <dwmw2@...radead.org>,
	Grazvydas Ignotas <notasas@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/4] usb: otg: twl4030-usb: Don't power down phy when it
 is in-use by charger.

Hi,

On Fri, May 18, 2012 at 12:50:10PM +1000, NeilBrown wrote:
> On Sun, 13 May 2012 20:14:09 +0200 Andi Shyti <andi.shyti@...il.com> wrote:
> > On Wed, May 09, 2012 at 07:40:40AM +1000, NeilBrown wrote:
> > > @@ -388,10 +388,16 @@ static void twl4030_phy_power(struct twl4030_usb *twl, int on)
> > >  					(PHY_CLK_CTRL_CLOCKGATING_EN |
> > >  						PHY_CLK_CTRL_CLK32K_EN));
> > >  	} else {
> > > -		__twl4030_phy_power(twl, 0);
> > >  		regulator_disable(twl->usb1v5);
> > >  		regulator_disable(twl->usb1v8);
> > >  		regulator_disable(twl->usb3v1);
> > > +		if (!regulator_is_enabled(twl->usb3v1))
> > > +			/* no-one else is requesting this
> > > +			 * so it is OK to power-down the
> > > +			 * phy.  Sometimes a charger might
> > > +			 * hold the regulator active.
> > > +			 */
> > > +			__twl4030_phy_power(twl, 0);
> > >  	}
> > 
> > Usually a regulator line is shared by more than one device and
> > regulator_is_enable() returns true if at least one of these
> > devices is holding the regulator. This means that here the check
> > will not work if this is your case.
> > 
> > Andi
> 
> This regulator is inside an MFD and it only feeds a very limited number of
> devices within that MFD.  So I don't think there is much room for confusion.
> 
> However is it a somewhat indirect method of signalling.  I want the charger
> to be able to tell the USB controller that it is using the PHY so please
> don't turn it off.  Doing that through the regulator seems simple and
> effective.
> Maybe there is a better way, but it isn't immediately clear what that would
> be.
> Suggestions welcome.

When using regulators I would keep track of his status internally
in the driver... 'true' if on or 'false' if of, in this way there
is no room for confusion.
But the mine is just a suggestion, you know the environment
better

Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/