linux-kernel - Re: [PATCH v4] iio: add LM3533 ambient-light-sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBB4C41.8000006@cam.ac.uk>
Date:	Tue, 22 May 2012 09:20:17 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	michael.hennerich@...log.com
CC:	Jonathan Cameron <jic23@...nel.org>,
	Johan Hovold <jhovold@...il.com>,
	Rob Landley <rob@...dley.net>,
	Richard Purdie <rpurdie@...ys.net>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Arnd Bergmann <arnd@...db.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v4] iio: add LM3533 ambient-light-sensor driver

On 5/22/2012 9:11 AM, Michael Hennerich wrote:
> On 05/22/2012 09:49 AM, Jonathan Cameron wrote:
>> On 5/22/2012 8:45 AM, Michael Hennerich wrote:
>>> On 05/21/2012 06:37 PM, Jonathan Cameron wrote:
>>>> Michael cc'd for comments on core support of some stuff that is also
>>>> in frequency drivers down the end of the email.
>>>>
>>>> On 05/21/2012 10:50 AM, Johan Hovold wrote:
>>>>> On Sat, May 19, 2012 at 09:48:23AM +0100, Jonathan Cameron wrote:
>>>>>> On 05/18/2012 02:07 PM, Johan Hovold wrote:
>>>>>> So to summarise, we get the following new sysfs-entries for the ALS
>>>>>> (where the first set replace targetX_Y):
>>>>>>
>>>>>> out_currentX_currentY_raw r/w, (0..255), X in 0..2, Y in 0..4
>>>>>> out_currentX_raw ro (0..255), X in 0..2
>>>>>>
>>>>>> Is there any support in core for the first set or should I simply
>>>>>> rename my target attributes?
>>>> No support in the core yet for this sort of thing..
>>>> Michael, any thoughts on this? In a sense it's very similar to
>>>> out_altvoltageX_frequencyY_raw etc...
>>>>
>>> Hi,
>>>
>>> Exactly it's similar to what we have on the DDS parts.
>>> The DDS parts would also benefit from a second index.
>>>
>>> Can someone think of an use case where we have 'differential' or
>>> 'modified'
>>> together with this pattern?
>>>
>>> If not we could use channel2 and introduce an new flag, but I fear
>>> that we end up using channel2 for too many things.
>>> So we should better introduce an new variable?
>>>
>> New variable. Tedious but channel2 is getting rather too overloaded.
>>
>>
>>
> Blah channel2 is not an option at all.
Gah. Good point.  Not enough coffee this morning...
> We need to generate an index on the postfix.
> And we can't pass this information via info_mask.
> So ext_info could be your friend?
Short term yes, though we may want more specific support for this
down the line (to make for coherent in kernel interface). Not yet
sure what form that will take though.

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/