linux-kernel - Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 May 2012 11:15:12 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	Ian Abbott <ian.abbott@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void
 __iomem *

On 2012-05-22 09:11, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote:
>> @@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev,
>>   	if (ret<  0)
>>   		return ret;
>>
>> -	devpriv->ioaddr = (void *)(unsigned long)it->options[0];
>> +	devpriv->ioaddr = (void __iomem *)(unsigned long)it->options[0];
>
>
> Obviously, your patch is fine, but I was wondering if it was a
> problem that it->options was only a 32 bit?  Seems like it would
> deserve a comment.

Yes, it's a bit of a strange driver, this one.  It's a driver for a 
module sitting on a PCI card, but there is no driver I know of for the 
PCI card, and I've no idea what's actually ioremap'ing the memory!

Maybe we should quietly drop it and see if anyone complains?

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/