linux-kernel - Re: v3.4 will not compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 May 2012 11:23:40 +0100
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	James Borum <james.borum@...il.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: v3.4 will not compile

On Mon, 2012-05-21 at 20:39 -0700, David Rientjes wrote:
> On Mon, 21 May 2012, James Borum wrote:
> 
> > fs/built-in.o: In function `gfs2_lock':
> > file.c:(.text+0x3d7689): undefined reference to `dlm_posix_lock'
> > file.c:(.text+0x3d76c8): undefined reference to `dlm_posix_unlock'
> > file.c:(.text+0x3d76e8): undefined reference to `dlm_posix_get'
> > fs/built-in.o: In function `gdlm_cancel':
> > lock_dlm.c:(.text+0x3e9e75): undefined reference to `dlm_unlock'
> > fs/built-in.o: In function `gdlm_lock':
> > lock_dlm.c:(.text+0x3ea082): undefined reference to `dlm_lock'
> > fs/built-in.o: In function `gdlm_unmount':
> > lock_dlm.c:(.text+0x3ea60e): undefined reference to `dlm_release_lockspace'
> > fs/built-in.o: In function `control_unlock':
> > lock_dlm.c:(.text+0x3ea7dd): undefined reference to `dlm_unlock'
> > fs/built-in.o: In function `sync_lock':
> > lock_dlm.c:(.text+0x3ea920): undefined reference to `dlm_lock'
> > fs/built-in.o: In function `gdlm_put_lock':
> > lock_dlm.c:(.text+0x3eb1fc): undefined reference to `dlm_unlock'
> > fs/built-in.o: In function `gdlm_mount':
> > lock_dlm.c:(.text+0x3eb5ad): undefined reference to `dlm_new_lockspace'
> > lock_dlm.c:(.text+0x3eb869): undefined reference to `dlm_unlock'
> > lock_dlm.c:(.text+0x3eb8d1): undefined reference to `dlm_release_lockspace'
> > make: *** [.tmp_vmlinux1] Error 1
> 
> I'm suspecting you have CONFIG_DLM=m while CONFIG_GFS2_FS=y.  Seems like 
> we'll need to require CONFIG_DLM to be built-in in such a configuration?
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
> diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
> --- a/fs/gfs2/Kconfig
> +++ b/fs/gfs2/Kconfig
> @@ -26,7 +26,7 @@ config GFS2_FS
>  config GFS2_FS_LOCKING_DLM
>  	bool "GFS2 DLM locking"
>  	depends on (GFS2_FS!=n) && NET && INET && (IPV6 || IPV6=n) && \
> -		HOTPLUG && DLM && CONFIGFS_FS && SYSFS
> +		HOTPLUG && (DLM=y) && CONFIGFS_FS && SYSFS

No, that's not it.  The problem is that DLM can't be a module if GFS_FS
is built in because GFS needs to use DLM functions (so DLM can be a
module as long GFS_FS is)

so this should be

&& (DLM=y || (DLM=m && GFS_FS=m))

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/