linux-kernel - Re: BFS 420: remove requeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAJd=RBCqpxWPLdziiNM+NZGUoObODjwH2m5Pj5Gvj9_U8Az1wA@mail.gmail.com>
Date:	Tue, 22 May 2012 20:46:45 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>,
	Hillf Danton <dhillf@...il.com>
Subject: Re: BFS 420: remove requeue_task

First, requeue_task has nothing to do with enqueuing task. Plus at the call
sites, schedule info should not be updated for enqueuing task. So remove it.

--- a/kernel/sched/bfs.c	Mon May 14 20:50:38 2012
+++ b/kernel/sched/bfs.c	Tue May 22 19:58:38 2012
@@ -724,10 +724,6 @@ static inline void enqueue_task_head(str
 	sched_info_queued(p);
 }

-static inline void requeue_task(struct task_struct *p)
-{
-	sched_info_queued(p);
-}

 /*
  * Returns the relative length of deadline all compared to the shortest
@@ -2808,7 +2804,6 @@ static void task_running_tick(struct rq
 	/* p->time_slice < RESCHED_US. We only modify task_struct under grq lock */
 	p = rq->curr;
 	grq_lock();
-	requeue_task(p);
 	set_tsk_need_resched(p);
 	grq_unlock();
 }
@@ -4567,7 +4562,6 @@ SYSCALL_DEFINE0(sched_yield)
 	p = current;
 	grq_lock_irq();
 	schedstat_inc(task_rq(p), yld_count);
-	requeue_task(p);

 	/*
 	 * Since we are going to call schedule() anyway, there's
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/