linux-kernel - Re: [PATCH] slab+slob: dup name string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBBAE95.6080608@parallels.com>
Date:	Tue, 22 May 2012 19:19:49 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Christoph Lameter <cl@...ux.com>
CC:	David Rientjes <rientjes@...gle.com>,
	<linux-kernel@...r.kernel.org>, <cgroups@...r.kernel.org>,
	<linux-mm@...ck.org>, Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string

On 05/22/2012 05:56 PM, Christoph Lameter wrote:
> On Mon, 21 May 2012, David Rientjes wrote:
>
>> This doesn't work if you kmem_cache_destroy() a cache that was created
>> when g_cpucache_cpu<= EARLY, the kfree() will explode.  That never
>> happens for any existing cache created in kmem_cache_init(), but this
>> would introduce the first roadblock in doing so.  So you'll need some
>> magic to determine whether the cache was allocated statically and suppress
>> the kfree() in such a case.
>
> Nope. Only slab management caches will be created that early. The patch is
> fine as is.
>
>

I think that's precisely David's point: that we might want to destroy 
them eventually.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/