[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMuHMdUox7MKzAM6etq6ptLyyxUMSZwSyXrfuTc-bvLiVrMhwA@mail.gmail.com>
Date: Tue, 22 May 2012 21:59:29 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@...hat.com>,
Bob Liu <lliubbo@...il.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Media Mailing List <linux-media@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL for 3.3-rc1] media updates
Hi Laurent,
On Mon, Apr 30, 2012 at 1:23 PM, Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
> On Wednesday 25 April 2012 17:12:49 Geert Uytterhoeven wrote:
>> On Sun, Jan 15, 2012 at 14:41, Mauro Carvalho Chehab wrote:
>> > Laurent Pinchart (18):
>> > [media] uvcvideo: Move fields from uvc_buffer::buf to uvc_buffer
>> > [media] uvcvideo: Use videobuf2-vmalloc
>>
>> It seems these change (3d95e932573c316ad56b8e2f283e26de0b9c891c
>> resp. 6998b6fb4b1c8f320adeee938d399c4d8dcc90e2) broke the
>> build for nommu a while ago, as uvc_queue_get_unmapped_area() was not
>> or was incorrectly updated:
>>
>> drivers/media/video/uvc/uvc_queue.c:254:23: error: 'struct
>> uvc_video_queue' has no member named 'count'
>> drivers/media/video/uvc/uvc_queue.c:255:18: error: 'struct
>> uvc_video_queue' has no member named 'buffer'
>> drivers/media/video/uvc/uvc_queue.c:256:19: error: 'struct vb2_buffer'
>> has no member named 'm'
>> drivers/media/video/uvc/uvc_queue.c:259:16: error: 'struct
>> uvc_video_queue' has no member named 'count'
>> drivers/media/video/uvc/uvc_queue.c:263:23: error: 'buf' undeclared
>> (first use in this function)
>>
>> Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/6171077/
>
> My bad, and thanks for the report. The following patch should fix this. Do you
> have a NOMMU system to test it on ?
No, I don't.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists