linux-kernel - Re: [PATCH] power: add knob for printing device resume times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120522202453.GA30723@kroah.com>
Date:	Tue, 22 May 2012 13:24:53 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sameer Nanda <snanda@...omium.org>
Cc:	len.brown@...el.com, pavel@....cz, rjw@...k.pl,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] power: add knob for printing device resume times

On Tue, May 22, 2012 at 12:16:45PM -0700, Sameer Nanda wrote:
> Added a new knob called /sys/powe/pm_print_times. Setting it to 1
> enables printing of time taken by devices to suspend and resume.
> Setting it to 0 disables this printing (unless overridden by
> initcall_debug kernel command line option).
> 
> Signed-off-by: Sameer Nanda <snanda@...omium.org>
> cc: Greg KH <gregkh@...uxfoundation.org>
> cc: Rafael J. Wysocki <rjw@...k.pl>
> cc: Steven Rostedt <rostedt@...dmis.org>
> ---
>  drivers/base/power/main.c  |    4 ++--
>  drivers/base/power/power.h |   11 +++++++++++
>  kernel/power/main.c        |   34 ++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+), 2 deletions(-)

Not getting into if this patch is correct or not, it's obviously wrong
in that you are adding a new sysfs file to the system, yet you did not
add a Documentation/ABI/ file documenting exactly what this file does
and how to use it.

Please redo it with that added, and fix the obvious typo in the
changelog body as well :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/