linux-kernel - Re: [PATCH] usb-hid-core: Set intfdata to NULL if probe fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBC0E66.809@redhat.com>
Date:	Wed, 23 May 2012 00:08:38 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb-hid-core: Set intfdata to NULL if probe fails

Hi,

On 05/23/2012 12:00 AM, Jiri Kosina wrote:
> On Tue, 22 May 2012, Hans de Goede wrote:
>
>> Well then lets work towards making it guaranteed, since I still believe
>> the following holds true:
>> 1) drvdata is for a driver to store a pointer to driver specific data
>> 2) If no driver is bound, there is no driver specific data associated with
>>     the device
>> 3) Thus logically drvdata should be NULL if no driver is bound.
>>
>> I'll do a patch for the USB-core to ensure that intfdata gets set to NULL
>> on probe failure.
>
> Hans,
>
> I believe this is a good thing per se, but shouldn't this rather be done
> in driver core, to guarantee that this hold across all buses?

Alan Stern said exactly the same thing :)

And I've just finished a patch doing exactly that. I'll send it to the
list right after this email.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/