[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120522224402.GN14339@google.com>
Date: Tue, 22 May 2012 15:44:02 -0700
From: Tejun Heo <tj@...nel.org>
To: Kent Overstreet <koverstreet@...gle.com>
Cc: linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
dm-devel@...hat.com, agk@...hat.com
Subject: Re: [Bcache v13 14/16] bcache: Request, io and allocation code
On Wed, May 09, 2012 at 11:11:25PM -0400, Kent Overstreet wrote:
> +int submit_bbio_split(struct bio *bio, struct cache_set *c,
> + struct bkey *k, unsigned ptr)
> +{
> + struct closure *cl = bio->bi_private;
> + struct bbio *b;
> + struct bio *n;
> + unsigned sectors_done = 0;
> +
> + closure_get(cl);
> +
> + bio->bi_sector = PTR_OFFSET(k, ptr);
> + bio->bi_bdev = PTR_CACHE(c, k, ptr)->bdev;
> +
> + do {
> + n = bio_split_get(bio, bio_max_sectors(bio), c);
> + if (!n) {
> + closure_put(cl);
> + return -ENOMEM;
> + }
> +
> + b = container_of(n, struct bbio, bio);
> +
> + bkey_copy_single_ptr(&b->key, k, ptr);
> + SET_KEY_SIZE(&b->key, KEY_SIZE(k) - sectors_done);
> + SET_PTR_OFFSET(&b->key, 0, PTR_OFFSET(k, ptr) + sectors_done);
> +
> + b->submit_time_us = local_clock_us();
> + generic_make_request(n);
> + } while (n != bio);
> +
> + return 0;
> +}
Where is @sectors_done updated?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists