linux-kernel - Re: ACPI and NUMA guys, please help to check if this patch is OK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1205222029590.28165@chino.kir.corp.google.com>
Date:	Tue, 22 May 2012 20:30:58 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	ethan zhao <ethan.kernel@...il.com>
cc:	linux-kernel@...r.kernel.org, Kurt Garloff <kurt@...loff.de>,
	Len Brown <len.brown@...el.com>
Subject: Re: ACPI and NUMA guys, please help to check if this patch is OK

On Wed, 23 May 2012, ethan zhao wrote:

> [PATCH] drivers/acpi/numa.c: Add localities checking code against
> proximity domains to slit_valid()
> 
>  Some buggy BIOS/ACPI will set different number to SLIT localities and
> SRAT proximity domains,
>  That will make NUMA configuration invalid and kernel will output
> information like following
> 
> NUMA:Warning:invalid distance parameter, from=-1 to=-1 distance=83
> 
> This patch adds some checking code to slit_valid() function in order
> to check theSLIT localities
> count against SRAT proximity domains number and give clear information
> about ACPI bug.
> 
> Signed-off-by: ethan.zhao <ethan.kernel@...il.com>

There's nothing in the ACPI spec that prohibits this and the result is 
non-fatal (it only emits a warning of the mismatch), so this patch is 
unnecessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/