linux-kernel - Re: [PATCH v2] testusb: expose looping forever option "l" to user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <op.weqsgwq33l0zgt@mpn-glaptop>
Date:	Tue, 22 May 2012 20:39:58 -0700
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>,
	"Du, ChangbinX" <changbinx.du@...el.com>
Cc:	"'David Rientjes'" <rientjes@...gle.com>,
	"'Sergei Shtylyov'" <sshtylyov@...sta.com>,
	"Fleming, Matt" <matt.fleming@...el.com>,
	"'balbi@...com'" <balbi@...com>, "'hpa@...or.com'" <hpa@...or.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'linux-usb@...r.kernel.org'" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2] testusb: expose looping forever option "l" to user

On Tue, 22 May 2012 19:43:05 -0700, Du, ChangbinX <changbinx.du@...el.com> wrote:
> The testusb.c tool has support for looping forever implemented, which
> may be useful for stress test, yet it is not exposed to the user, so
> even though the code is there, it cannot be used.  This commit adds
> "l" to the set of options handled by the application which enables
> the feature.
>
> Also, I collate help information for each command line option to make
> it easier to use for novice.
>
> Signed-off-by: Du Changbin <changbinx.du@...el.com>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
>  tools/usb/testusb.c |   21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> index 0aac3ff..7a7adf3 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
> @@ -422,7 +422,7 @@ int main (int argc, char **argv)
>  	/* for easy use when hotplugging */
>  	device = getenv ("DEVICE");
>-	while ((c = getopt (argc, argv, "D:aA:c:g:hns:t:v:")) != EOF)
> +	while ((c = getopt (argc, argv, "D:aA:c:g:hlns:t:v:")) != EOF)
>  	switch (c) {
>  	case 'D':	/* device, if only one */
>  		device = optarg;
> @@ -465,10 +465,21 @@ int main (int argc, char **argv)
>  	case 'h':
>  	default:
>  usage:
> -		fprintf (stderr, "usage: %s [-n] [-D dev | -a | -A usbfs-dir]\n"
> -			"\t[-c iterations]  [-t testnum]\n"
> -			"\t[-s packetsize] [-g sglen] [-v vary]\n",
> -			argv [0]);
> +		fprintf (stderr,
> +			"usage: %s [options]\n"
> +			"Options:\n"
> +			"\t-D dev		only test specific device\n"
> +			"\t-A usbfs-dir\n"
> +			"\t-a		test all recognized devices\n"
> +			"\t-l		loop forever(for stress test)\n"
> +			"\t-t testnum	only run specified case\n"
> +			"\t-n		no test running, show devices to be tested\n"
> +			"Case arguments:\n"
> +			"\t-c iterations	default 1000\n"
> +			"\t-s packetsize	default 512\n"
> +			"\t-g sglen	default 32\n"
> +			"\t-v vary		default 512\n",
> +			argv[0]);
>  		return 1;
>  	}
>  	if (optind != argc)


-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/