lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 May 2012 08:55:38 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Yanmin Zhang <yanmin_zhang@...ux.intel.com> Cc: David Miller <davem@...emloft.net>, kunx.jiang@...el.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ipv4: fix the rcu race between free_fib_info and ip_route_output_slow On Wed, 2012-05-23 at 14:47 +0800, Yanmin Zhang wrote: > On Wed, 2012-05-23 at 08:27 +0200, Eric Dumazet wrote: > > On Wed, 2012-05-23 at 14:15 +0800, Yanmin Zhang wrote: > > > > > > > > Besides fi->fib_dev here, we need check fi->fib_hash, fi->fib_lhash, > > > and nexthop_nh->nh_hash. > > > > No, its not needed. > I am checking it now. > fib_create_info=>fib_find_info, but fib_find_info is not protected by > fib_info_lock. See the codes: > > > link_it: > ofi = fib_find_info(fi); > if (ofi) { > fi->fib_dead = 1; > free_fib_info(fi); > ofi->fib_treeref++; > return ofi; > } > > > > > I am sending a patch, because I feel this area is too complex for non > > netdev guys. > Indeed, it's complicated. I will test your patches. Please hold on, I'll send a v2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists