lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 May 2012 05:33:12 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Mark Asselstine <mark.asselstine@...driver.com> Cc: linux-kernel@...r.kernel.org, asselsm@...il.com Subject: Re: [PATCH v2 3/3] trace-cmd: setting plugin to 'nop' clears data before it's recorded On Sun, 2012-04-08 at 11:38 -0400, Mark Asselstine wrote: > commit e09a5db1a929ab668c273b87c4f0a32b81e1c21a > [trace-cmd: Add trace-cmd record --date option] > > moved the call to disable_all() in trace_record() from after record_data() > to before it. Unfortunately disable_all() sets 'nop' in 'current_tracer' > which has the side affect of clearing 'trace', thus all the latency tracer > reports are empty/useless. Here we make disable_all() optionally call > set_plugin() thus, where we need to, we can delay the disabling of the tracer > until we have had a chance to capture 'trace'. We have added this delayed > behavior to trace_record() to fix the latency reports, for all other calls to > disable_all() we continue to have set_plugin() called. > Just letting you know that I just pushed your changes to my repo. Sorry for being late, I got side-tracked, and forgot about your changes. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists