linux-kernel - Re: [PATCH] Guard check in module loader against integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r4ubxfjp.fsf@rustcorp.com.au>
Date:	Wed, 23 May 2012 21:41:54 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] Guard check in module loader against integer overflow

On Tue, 22 May 2012 15:56:13 +0100, David Howells <dhowells@...hat.com> wrote:
> The check:
> 
> 	if (len < hdr->e_shoff + hdr->e_shnum * sizeof(Elf_Shdr))
> 
> may not work if there's an overflow in the right-hand side of the condition.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

Thanks; though the sanity checks are merely against accidents, not
malice, it's worth fixing.

Applied,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/