linux-kernel - Re: [PATCH for-3.6] debugfs: change parameter check in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120523132912.GA23310@kroah.com>
Date:	Wed, 23 May 2012 06:29:12 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-3.6] debugfs: change parameter check in
 debugfs_remove() functions

On Wed, May 23, 2012 at 03:13:07PM +0200, Arend van Spriel wrote:
> The dentry parameter in debugfs_remove() and debugfs_remove_recursive()
> is checked being a NULL pointer. To make cleanup by callers easier this
> check is extended using the IS_ERR_OR_NULL macro instead because the
> debugfs_create_... functions can return a ERR_PTR() value.
> 
> Signed-off-by: Arend van Spriel <arend@...adcom.com>
> ---
> I was adding the check in driver code before calling the recursive remove,
> but considered it might be a better idea to do it in debugfs itself.

Yes, nice change, thanks.

I'll queue it up after 3.5-rc1 is out.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/