lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 May 2012 10:39:34 +0900 From: Minho Ban <mhban@...sung.com> To: Chanyeol Park <chanyeol.park@...sung.com> Cc: Gustavo Padovan <gustavo@...ovan.org>, Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, "David S. Miller" <davem@...emloft.net>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [RFC/PATCH] Bluetooth: prevent double l2cap_chan_destroy On 05/22/2012 09:23 PM, Chanyeol Park wrote: > Hi > > On 2012년 05월 22일 11:50, Minho Ban wrote: >> @@ -1343,10 +1343,10 @@ static void l2cap_conn_del(struct hci_conn *hcon, int err) >> l2cap_chan_lock(chan); >> >> l2cap_chan_del(chan, err); >> + chan->ops->close(chan->data); >> >> l2cap_chan_unlock(chan); >> >> - chan->ops->close(chan->data); >> l2cap_chan_put(chan); >> } > I think this patch does not make sense Because inside chan->ops->close() "chan" could be freed in the l2cap_chan_destroy(). > I agree, thanks for pointing out. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists