linux-kernel - Re: [PATCH] slab+slob: dup name string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBCF951.3040105@parallels.com>
Date:	Wed, 23 May 2012 18:50:57 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Christoph Lameter <cl@...ux.com>
CC:	James Bottomley <James.Bottomley@...senPartnership.com>,
	David Rientjes <rientjes@...gle.com>,
	<linux-kernel@...r.kernel.org>, <cgroups@...r.kernel.org>,
	<linux-mm@...ck.org>, Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string

On 05/23/2012 06:48 PM, Christoph Lameter wrote:
> On Wed, 23 May 2012, James Bottomley wrote:
>
>>>> So, why not simply patch slab to rely on the string lifetime being the
>>>> cache lifetime (or beyond) and therefore not having it take a copy?
>
> Well thats they way it was for a long time. There must be some reason that
> someone started to add this copying business....  Pekka?
>
The question is less why we added, but rather why we're keeping.

Of course reasoning about why it was added helps (so let's try to 
determine that), but so far the only reasonably strong argument in favor 
of keeping it was robustness.

But given that a lot of systems still uses SLAB, and we have no record 
of bugs due to dangling name pointers, this might very well be 
overzealousness on our part.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/