linux-kernel - Re: mc13xxx-core: kernel hangs after 'regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 May 2012 12:29:54 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	marc@...esign.com.au, Samuel Ortiz <sameo@...ux.intel.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Philippe Rétornaz <philippe.retornaz@...l.ch>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: mc13xxx-core: kernel hangs after 'regmap_read'

On Wed, May 23, 2012 at 11:18 AM, Fabio Estevam <festevam@...il.com> wrote:

> Removing only the line that sets bits_per_word:
>
> --- a/drivers/mfd/mc13xxx-spi.c
> +++ b/drivers/mfd/mc13xxx-spi.c
> @@ -73,7 +73,6 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
>
>        dev_set_drvdata(&spi->dev, mc13xxx);
>        spi->mode = SPI_MODE_0 | SPI_CS_HIGH;
> -       spi->bits_per_word = 32;
>
>        mc13xxx->dev = &spi->dev;
>        mutex_init(&mc13xxx->lock);
>
>
> , does allow the kernel to boot, but the mx13xxx driver is not probed anymore:

The reason for the mc13xxx not probing is because it tries to read the
mc13xxx version register and does not find a valid PMIC ID.

I did a dump of all the mc13xxx registers and all of them return the
same value of 0x810, which means we are not reading SPI correctly via
regmap.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/