linux-kernel - Re: [dm-devel] [Bcache v13 09/16] Bcache: generic utility code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH+dOx+DhSweOvZZv3dVcedeBBZZ0=zondmKTDzMVXPdWZr=JA@mail.gmail.com>
Date:	Wed, 23 May 2012 11:33:30 -0400
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Tejun Heo <tejun@...gle.com>, linux-bcache@...r.kernel.org,
	agk@...hat.com, linux-kernel@...r.kernel.org, dm-devel@...hat.com
Subject: Re: [dm-devel] [Bcache v13 09/16] Bcache: generic utility code

On Wed, May 23, 2012 at 11:15 AM, Vivek Goyal <vgoyal@...hat.com> wrote:
> Another thing is that keep variable names consistent. Last time I looked,
> same name "c" was being used to represent cached_dev or cache_set or
> something else too. If we keep variable name same to represent same
> data structure, it becomes easier to read the code. I was totally lost
> and always had to go back to figure out what "c" is representing, what
> "d" is representing etc.

Yeah, those examples are both cases where the struct was split -
struct cache was broken into struct cache and cache_set, struct
bcache_device was split off from cached_dev.

I've been fixing things as I go along, but probably I should just do
them all at once and be done with it, damn the code churn.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/