linux-kernel - Re: [PATCH V2] x86/pci: sta2x11: fix a compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 May 2012 01:25:56 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Alessandro Rubini <rubini@...dd.com>
cc:	x86@...nel.org, Giancarlo Asnaghi <giancarlo.asnaghi@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] x86/pci: sta2x11: fix a compiler warning

On Wed, 23 May 2012, Alessandro Rubini wrote:

> swiotlb_free_coherent(), exported by lib/swiotlb.b, cannot be used in
> dma_ops, because it doesn't want the "attrs" argument.  Add a wrapper,
> like other users of the function already do.
> 
> Signed-off-by: Alessandro Rubini <rubini@...dd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@...com>
> ---
> 
> [V2: same patch, message fixed (sorry, I made a mess in the editor)]
> 
> Actually, we may instead add "args" to the exported functions in
> lib/swiotlb.  This would then remove a few other similar wrappers that
> do nothing.  If it's considered useful, I can propose a patch for that.

Yes please. Do nothing wrappers are harmful espcially if they get
common.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/