[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FBDF0CB.4040501@nod.at>
Date: Thu, 24 May 2012 10:26:51 +0200
From: Richard Weinberger <richard@....at>
To: dedekind1@...il.com
CC: Shmulik Ladkani <shmulik.ladkani@...il.com>,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
Heinz.Egger@...utronix.de, tim.bird@...sony.com, tglx@...utronix.de
Subject: Re: [PATCH] [RFC] UBI: Implement Fastmap support
On 24.05.2012 10:19, Artem Bityutskiy wrote:
>> After thinking a bit more about this case I think the best we can to
>> is
>> switching to read-only mode if ubi_update_fastmap()
>> fails.
>>
> Unless it fails because of -EIO, which means the PEB may become bad and
> you need to pick a different one and schedule the faulty one for
> torturing and marking as bad.
Wouldn't make more sense if ubi_update_fastmap() handles the -EIO case
internally?
Currently (as of v7) both callers ubi_volume_notify() and
ubi_wl_get_peb() check the return value of ubi_update_fastmap()
and set UBI into read-only mode if ubi_update_fastmap() fails.
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists