| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 May 2012 09:53:41 +0100 From: Ian Abbott <abbotti@....co.uk> To: Dan Carpenter <dan.carpenter@...cle.com> CC: H Hartley Sweeten <hartleys@...ionengravers.com>, Ian Abbott <ian.abbott@....co.uk>, Linux Kernel <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, "fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> Subject: Re: [PATCH] staging: comedi: remove this_board macro in the s526 driver On 2012-05-23 20:07, Dan Carpenter wrote: > On Wed, May 23, 2012 at 11:28:32AM -0500, H Hartley Sweeten wrote: >> This would allow comedi_recognize() to walk the boardinfo >> to find the match without all the ugly casts. > > That function wouldn't be so bad if we just removed all the consts. > There is no point because we drop all of them anyway when we return > the struct. Well maybe some of the consts. We could use const char **name_ptr instead of const char *const *name_ptr. *name_ptr is never modified, but as name_ptr is just a local variable, the compiler can figure that out for itself without the extra const. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists