linux-kernel - Re: [patch -linus] regmap: REMAP_IRQ should select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1205231735100.8785@chino.kir.corp.google.com>
Date:	Wed, 23 May 2012 17:36:38 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN
 itself

On Wed, 23 May 2012, Mark Brown wrote:

> > Multi-level pure selects *should* work correctly. So you can select
> > stuff that then in turn selects other stuff - and that should all be
> > fine.
> 
> They're supposed to, and mostly do, but there's been some fragility
> there.  That said there's not been anything recently, perhaps I just got
> hit with fallout from some development that was going on.
> 
> > It's *dependencies* that do not work.
> 
> Right, and nor are they supposed to since it's not clear what they
> should do.  That's a completely different thing.
> 

So my patch to select IRQ_DOMAIN for REGMAP_IRQ is correct since 
REGMAP_IRQ now requires IRC_DOMAIN since the commit listed in the 
changelog.

What's fragile is going around and adding "select IRQ_DOMAIN" to 
everything that does "select REGMAP_IRQ".  So I removed that and just made 
IRQ_DOMAIN select REGMAP_IRQ itself.

So can this be merged or what's the issue?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/