linux-kernel - Re: [PATCH 05/16] perf: Add attribute to filter out user callchains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337857068.9783.113.camel@laptop>
Date:	Thu, 24 May 2012 12:57:48 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	acme@...hat.com, mingo@...e.hu, paulus@...ba.org,
	cjashfor@...ux.vnet.ibm.com, fweisbec@...il.com,
	eranian@...gle.com, gorcunov@...nvz.org, tzanussi@...il.com,
	mhiramat@...hat.com, robert.richter@....com, fche@...hat.com,
	linux-kernel@...r.kernel.org, masami.hiramatsu.pt@...achi.com,
	drepper@...il.com, asharma@...com, benjamin.redelings@...cent.org
Subject: Re: [PATCH 05/16] perf: Add attribute to filter out user callchains

On Wed, 2012-05-23 at 21:32 +0200, Jiri Olsa wrote:
> Add the new exclude_user_callchain attribute to filter out
> frame pointer based user callchains.
> 
> This is something we want to select when we use the dwarf cfi
> callchain mode, because frame pointer based user callchains are
> useless in this mode.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---
>  include/linux/perf_event.h |    4 +++-
>  kernel/events/callchain.c  |    4 ++--
>  kernel/events/core.c       |    3 ++-
>  kernel/events/internal.h   |    3 ++-
>  4 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index dcdc97e..df6ba37 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -275,7 +275,9 @@ struct perf_event_attr {
>  				exclude_host   :  1, /* don't count in host   */
>  				exclude_guest  :  1, /* don't count in guest  */
>  
> -				__reserved_1   : 43;
> +				exclude_user_callchain : 1, /* only record kernel callchains */

*sigh* I guess if we're going to do this we might as well do a complete
option set and also allow excluding kernel and possible hv if anybody
actually implemented that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/