linux-kernel - Re: [PATCH] swiotlb: add "dma_attrs" argument to alloc and free, to match dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBE5085.2090904@gmail.com>
Date:	Thu, 24 May 2012 08:15:17 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Alessandro Rubini <rubini@...dd.com>
CC:	linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-ia64@...r.kernel.org, linux-mips@...ux-mips.org,
	Giancarlo Asnaghi <giancarlo.asnaghi@...com>,
	Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Thomas Gleixner <tglx@...utronix.de>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH] swiotlb: add "dma_attrs" argument to alloc and free,
 to match dma_map_ops

On 05/24/2012 04:44 AM, Alessandro Rubini wrote:
> The alloc and free pointers within "struct dma_map_ops" receive a
> pointer to dma_attrs that was not present in the generic swiotlb
> functions.  For this reason, a few files had a local wrapper for the
> free function that just removes the attrs argument before calling the
> generic function.
>
> This patch adds the extra argument to generic functions and removes
> such wrappers when they are no more needed.  This also fixes a
> compiler warning for sta2x11-fixup.c, that would have required yet
> another wrapper.
>
> Signed-off-by: Alessandro Rubini<rubini@...dd.com>
> Acked-by: Giancarlo Asnaghi<giancarlo.asnaghi@...com>
> Cc: Tony Luck<tony.luck@...el.com>
> Cc: Fenghua Yu<fenghua.yu@...el.com>
> Cc: Ralf Baechle<ralf@...ux-mips.org>
> Cc: Guan Xuetao<gxt@...c.pku.edu.cn>
> Cc: Thomas Gleixner<tglx@...utronix.de>
> Cc: Kyungmin Park<kyungmin.park@...sung.com>
> Cc: FUJITA Tomonori<fujita.tomonori@....ntt.co.jp>
> Cc: Konrad Rzeszutek Wilk<konrad.wilk@...cle.com>
> ---
>   arch/ia64/kernel/pci-swiotlb.c       |   11 ++---------
>   arch/mips/cavium-octeon/dma-octeon.c |    4 ++--
>   arch/unicore32/mm/dma-swiotlb.c      |   22 ++--------------------
>   arch/x86/kernel/pci-swiotlb.c        |   11 ++---------
>   arch/x86/pci/sta2x11-fixup.c         |    3 ++-
>   include/linux/swiotlb.h              |    7 ++++---
>   lib/swiotlb.c                        |    5 +++--
>   7 files changed, 17 insertions(+), 46 deletions(-)
>

This looks sane (although I haven't tested it).  For the OCTEON bits:

Acked-by: David Daney <david.daney@...ium.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/