linux-kernel - Re: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 May 2012 18:26:05 +0200
From:	Borislav Petkov <bp@...64.org>
To:	"Liu, Jinsong" <jinsong.liu@...el.com>
Cc:	Borislav Petkov <bp@...64.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (v2)

On Thu, May 24, 2012 at 04:15:02PM +0000, Liu, Jinsong wrote:
> The reason is, if we do so, it would be covered by native misc_register(&mce_chrdev_device) later when native kernel init (xen init first and then start native kernel).
> Under such case, if linux running under xen platform, /dev/mcelog point to vcpu, that's pointless since it cannot get any mcelog from physical cpu (which owned by xen).
> 
> Yes, we can use another misc device like /dev/xen-mcelog, w/ another device minor like 226, but that's not good for userspace mcelog tools. As far as I know, Novell mcelog use unified /dev/mcelog interface for linux running under either bare metal or xen platform.

Maybe create a symlink in /dev/mcelog pointing to /dev/xen-mcelog?

That should solve it.

> This patch just do redirection at xen code path, and that would not
> hurt anything to native kernel.

My concern is that if we remove /dev/mcelog one day, xen people will
cry.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/