linux-kernel - Re: [PATCH] Drop superfluous setting of i2c_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337877626.22505.30.camel@x61.thuisdomein>
Date:	Thu, 24 May 2012 18:40:26 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Sascha Hauer <kernel@...gutronix.de>,
	Russell King <linux@....linux.org.uk>,
	Paul Mundt <lethal@...ux-sh.org>,
	Magnus Damm <magnus.damm@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drop superfluous setting of i2c_board_info.type

On Thu, 2012-05-24 at 18:22 +0200, Uwe Kleine-König wrote:
> On Thu, May 24, 2012 at 04:38:23PM +0200, Paul Bolle wrote:
> > 1) This is apparently legal. Doesn't gcc issue a warning for this?
> I wondered about that too, gcc doesn't even warn when the two values are
> different. See for example commit
> bd9e310dca15c9987256f67af19f9f42426e7493.

In that case it were two strings ("rtc-pcf8563" versus "pcf8563"). Why
should gcc care? Or is there something going on behind the scenes which
somehow depends on the contents of the string?
 
> >  arch/arm/mach-imx/mach-cpuimx35.c     |    1 -
> >  arch/arm/mach-imx/mach-cpuimx51sd.c   |    1 -
> I already submitted a patch for the imx bits with Message id
> 1335989287-10094-1-git-send-email-u.kleine-koenig@...gutronix.de.
> (e.g.
> http://mid.gmane.org/1335989287-10094-1-git-send-email-u.kleine-koenig@pengutronix.de)

Thanks. I missed that one, obviously. Should I just drop that part of
the patch and resend?

By the way, together with my previous patch (Message-ID
1337869829.22505.15.camel@....thuisdomein , probably not yet archived on
the web) we have found all instances of this issue, haven't we?

> Don't know if Sascha took it already. If he did, he didn't tell me.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/