linux-kernel - Re: [GIT PULL for v3.5-rc1] media updates for v3.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyt2OFOsr5uCpQ6nrur4zhHhmWUJrvMgLH_Wy1niTbC6w@mail.gmail.com>
Date:	Thu, 24 May 2012 13:42:45 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL for v3.5-rc1] media updates for v3.5

Btw, I only noticed now, because I normally don't build DVB on my main
machine with "oldconfig" - why the hell does DVB add tuners with
"default m"?

Why would *anybody* with an old config ever want to get those new
drivers as modules?

Get rid of all the stupid

  default m if DVB_FE_CUSTOMISE

because there's no reason for them. If somebody wants that module,
they can damn well press the 'm' button. There's absolutely no reason
for it to default to on.

This is true of *all* drivers. No driver (and certainly DVB is not at
all an exception) is so important that it should be "default m" (or
y).

There are a few valid reasons to use "default m/y", but I don't see
that that is the case here:

 - if you have an *existing* driver that got split up, and "make
oldconfig" with that old driver enabled would result in it no longer
supporting the same capability, then a

     default OLD_DRIVER_WAS_ENABLED

   is appropriate - it makes "oldconfig" work the way people expect it to work.

   But this is only when that piece of hardware used to be supported
already, it's irrelevant for new hardware.

 - if it's *such* a basic piece of hardware that you simply don't want
to bother the user with an insane default. Like supporting an ATKBD
driver on a PC etc.

   This simply isn't true for media devices.

So stop doing the silly "enable this driver by default for old
configurations". It's *wrong*.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/