linux-kernel - Re: [PATCH 1/2] mfd: select REGMAP_I2C for config MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4FBEC294.1000707@samsung.com>
Date:	Fri, 25 May 2012 08:21:56 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 1/2] mfd: select REGMAP_I2C for config MFD_MAX77693

Hi Axel Lin,

On 05/24/2012 05:56 PM, Axel Lin wrote:

> max77693 driver uses regmap api, thus need to select REGMAP_I2C.
> This fixes below build error when CONFIG_REGMAP=y && CONFIG_REGMAP_I2C=m:
> 
>   LD      init/built-in.o
> drivers/built-in.o: In function `max77693_i2c_probe':
> clk-fixed-factor.c:(.text+0x541f8): undefined reference to `devm_regmap_init_i2c'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4db63b1..e129c82 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -426,6 +426,7 @@ config MFD_MAX77693
>  	bool "Maxim Semiconductor MAX77693 PMIC Support"
>  	depends on I2C=y && GENERIC_HARDIRQS
>  	select MFD_CORE
> +	select REGMAP_I2C
>  	help
>  	  Say yes here to support for Maxim Semiconductor MAX77693.
>  	  This is a companion Power Management IC with Flash, Haptic, Charger,


I sent this patch yesterday due to same issue and it was applied to
mfd-2.6.git
by Samuel Ortiz. You can check it on below URL.
http://www.spinics.net/lists/kernel/msg1346801.html

Thank you,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/