[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.1205251018550.26786@kaball-desktop>
Date: Fri, 25 May 2012 10:19:10 +0100
From: Stefano Stabellini <stefano.stabellini@...citrix.com>
To: Stefano Stabellini <Stefano.Stabellini@...citrix.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>
Subject: Re: [Xen-devel] [PATCH 4/4] xen/events: Add WARN_ON when quick lookup
found invalid type.
On Fri, 25 May 2012, Stefano Stabellini wrote:
> > @@ -939,8 +944,10 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
> > xen_irq_info_virq_init(cpu, irq, evtchn, virq);
> >
> > bind_evtchn_to_cpu(evtchn, cpu);
> > + } else {
> > + struct irq_info *info = info_for_irq(irq);
> > + WARN_ON(info == NULL || info->type != IRQT_VIRQ);
> > }
> > -
> > out:
> > mutex_unlock(&irq_mapping_update_lock);
> >
>
> I don't want to nitpick but you removed 2 out of 3 spaced before the out
> label.
I meant newlines.
> In any case:
>
> Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists