linux-kernel - Re: [PATCH] misc: emif: fix compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120525092927.GI3850@arwen.pp.htv.fi>
Date:	Fri, 25 May 2012 12:29:28 +0300
From:	Felipe Balbi <balbi@...com>
To:	"Shilimkar, Santosh" <santosh.shilimkar@...com>
Cc:	Felipe Balbi <balbi@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>, arnd@...db.de,
	svadivu@...com, aneesh@...com
Subject: Re: [PATCH] misc: emif: fix compilation error

On Fri, May 25, 2012 at 02:40:18PM +0530, Shilimkar, Santosh wrote:
> On Fri, May 25, 2012 at 1:41 PM, Felipe Balbi <balbi@...com> wrote:
> > commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
> > Emif driver with initcall) introduced a compile
> > error by not removing module_init() when adding
> > postcore_initcall().
> >
> > This problem would've been caught by just compiling
> > the driver as module.
> >
> > Fix the issue by removing module_init() from the
> > driver.
> >
> > Signed-off-by: Felipe Balbi <balbi@...com>
> > ---
> >  drivers/misc/emif.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
> > index 36fda8e..8725ea9 100644
> > --- a/drivers/misc/emif.c
> > +++ b/drivers/misc/emif.c
> 
> This driver is in drivers/memory now and this patch is
> certainly not applicable. Looks like you might have seen
> this issue with the older, internal version of the driver.

could be.. I probably merged something I shouldn't on my master branch
;-)

Weird is that my master is built on top of v3.4... anyway.. forget about
this patch, sorry for the noise.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)