linux-kernel - Re: [PATCH 02/16] perf: Add ability to attach registers dump to sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 May 2012 12:01:23 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Stephane Eranian <eranian@...gle.com>, acme@...hat.com,
	mingo@...e.hu, paulus@...ba.org, cjashfor@...ux.vnet.ibm.com,
	fweisbec@...il.com, gorcunov@...nvz.org, tzanussi@...il.com,
	mhiramat@...hat.com, robert.richter@....com, fche@...hat.com,
	linux-kernel@...r.kernel.org, masami.hiramatsu.pt@...achi.com,
	drepper@...il.com, asharma@...com, benjamin.redelings@...cent.org
Subject: Re: [PATCH 02/16] perf: Add ability to attach registers dump to
 sample

On Thu, 2012-05-24 at 13:52 +0200, Jiri Olsa wrote:
> 
> My intention was to make this general. I could just add
> bitmask for each type (user regs mask for now) but I wanted
> to be consistent with other SAMPLE_* stuff..
> 
> So current patch adds PERF_SAMPLE_REGS sample_type bit.
> Once it is set, the 'sample_regs' value is checked for what
> type of registers you want for sample.
> 
> Each type then has separate bitmask in case you want different
> registers for each type. Allowing whatever combination of regs dump
> being added to the sample, since it seems there's no firm
> decision on what combination might be needed.
> 
> Sure we can make the same with bitmasks for each regs type,
> and check the presence in sample by bitmask being not empty. 

Right, I don't know. But none of this was in the changelog.

Also, I just checked, there's architectures with more than 64 GP
registers ;-) (IA64 has 128 64bit integer registers for instance).

Now IA64 is the only one I could find, and we don't actually support
perf for it, and seeing how 'popular' IA64 is we might never, but still.





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/