[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <13720.1337959203@redhat.com>
Date: Fri, 25 May 2012 16:20:03 +0100
From: David Howells <dhowells@...hat.com>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: dhowells@...hat.com, viro@...IV.linux.org.uk,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
hch@...radead.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH 00/16] vfs: atomic open v4 (part 1)
Miklos Szeredi <miklos@...redi.hu> wrote:
> > Also, does it make sense to combine:
> >
> > if (!S_ISREG(nd->inode->i_mode))
> > will_truncate = 0;
> >
> > with:
> >
> > int will_truncate = open_flag & O_TRUNC;
> >
> > up at the top of the function.
>
> We need to check nd->inode->i_mode *after* the lookup. So top of the
> function is not a good place.
Good point.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists