linux-kernel - Re: [PATCH] scsi: fix async probe regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 May 2012 18:05:07 +0100
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Meelis Roos <mroos@...ux.ee>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] scsi: fix async probe regression

On Fri, 2012-05-25 at 09:39 -0700, Dan Williams wrote:
> Commit a7a20d1 "[SCSI] sd: limit the scope of the async probe domain"
> moved sd probe work out of reach of wait_for_device_probe().  Allow it
> to be synced via scsi_complete_async_scans().
> 
> Cc: David Miller <davem@...emloft.net>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Reported-by: Meelis Roos <mroos@...ux.ee>
> Tested-by: Meelis Roos <mroos@...ux.ee>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
> 
>  So this is the stop gap that allows us to keep a7a20d1 as a fix for a
>  resume deadlock, and gives us time to figure out how to clarify
>  async_synchronize_full() properly in the 3.6 timeframe.
> 
>  drivers/scsi/scsi_scan.c |   12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 01b0374..41f9192 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -141,13 +141,13 @@ struct async_scan_data {
>   * started scanning after this function was called may or may not have
>   * finished.
>   */
> -int scsi_complete_async_scans(void)
> +static void __scsi_complete_async_scans(void)

Rather than wrappering the function, can we just fix it?

Put the async_synchronize_full_domain(&scsi_sd_probe_domain); at the
bottom with an out: label and make the only other return in the function
become a goto out;

Thanks,

James




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/