linux-kernel - Re: 3.4.0-02580-g72c04af regression on sparc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201205252127.21436.rjw@sisk.pl>
Date:	Fri, 25 May 2012 21:27:21 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	James Bottomley <jejbbe@...senpartnership.com>,
	Dan Williams <dan.j.williams@...el.com>,
	David Miller <davem@...emloft.net>, mroos@...ux.ee,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: 3.4.0-02580-g72c04af regression on sparc64 - partitions not recognized

On Friday, May 25, 2012, Alan Stern wrote:
> On Fri, 25 May 2012, James Bottomley wrote:
> 
> > > > This is actually looks wrong: it works if SCSI is built in, but it's a
> > > > nop if SCSI is a module (the nop function is gated by the else clause of
> > > > #ifdef CONFIG_SCSI)
> > > > 
> > > > Rafael, you added this not via the SCSI tree,
> > > 
> > > That's correct, it was committed directly by Linus.
> > > 
> > > > is that the intention?
> > > 
> > > Pretty much it is.
> > > 
> > > The code snippet is slightly out of context and it is a part of the
> > > software_resume() routine, which is only called when the kernel's built-in
> > > image reading code checks whether or not the image is present.  It won't
> > > work anyway if SCSI is not built in.
> > 
> > I don't understand this.
> > 
> > Why would it make a difference whether SCSI is modular at hybernation
> > resume time?  The reason it makes a difference at boot time is because
> > there's no initrd to wait for the scans and mount the root if we're not
> > modular, so the init path has to do it.  However, when resuming an
> > image, the module is already loaded into that image, so there should be
> > no difference at all between steps taken in the modular and non-modular
> > cases.
> 
> I think Rafael is referring to the boot kernel -- the one that reads in
> the hibernation image initially.

That's correct.

> Whether or not the boot kernel can have modular drivers isn't clear to me;

It can, but then the code in question is irrelevant and the resume has to
be triggered in a different way.  For example, by writing to
/sys/power/resume from the initrd boot scripts.

> I don't know when the check for a valid image in the swap area is carried
> out in relation to starting up the initramfs task.

This particular one is carried out before the initrd is loaded.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/