linux-kernel - Re: [PATCH] [emu10k1]: remove the kcallloc cast (reported from make coccicheck's drop_kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hmx4w7q47.wl%tiwai@suse.de>
Date:	Fri, 25 May 2012 08:04:56 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [emu10k1]: remove the kcallloc cast (reported from make coccicheck's drop_kmalloc_cast.cocci)

At Thu, 24 May 2012 19:32:29 +0530,
Devendra Naga wrote:
> 
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>

I don't think removing it improves anything much.
It's cast to __user pointer, and this rather helps to catch the
caution.


thanks,

Takashi

> ---
>  sound/pci/emu10k1/emufx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
> index dae4050..272f8ac 100644
> --- a/sound/pci/emu10k1/emufx.c
> +++ b/sound/pci/emu10k1/emufx.c
> @@ -1815,7 +1815,7 @@ static int __devinit _snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
>  
>  	if ((icode = kzalloc(sizeof(*icode), GFP_KERNEL)) == NULL)
>  		return -ENOMEM;
> -	if ((icode->gpr_map = (u_int32_t __user *)
> +	if ((icode->gpr_map =
>  	     kcalloc(256 + 160 + 160 + 2 * 512, sizeof(u_int32_t),
>  		     GFP_KERNEL)) == NULL ||
>              (controls = kcalloc(SND_EMU10K1_GPR_CONTROLS,
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/