linux-kernel - Re: [PATCH v2 08/14] block: Kill bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 May 2012 09:43:03 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Vivek Goyal <vgoyal@...hat.com>
CC:	Kent Overstreet <koverstreet@...gle.com>,
	<linux-kernel@...r.kernel.org>, <linux-bcache@...r.kernel.org>,
	<dm-devel@...hat.com>, <linux-fsdevel@...r.kernel.org>,
	<tj@...nel.org>, <axboe@...nel.dk>, <agk@...hat.com>,
	<neilb@...e.de>, <drbd-dev@...ts.linbit.com>,
	<mpatocka@...hat.com>, <sage@...dream.net>,
	<yehuda@...newdream.net>
Subject: Re: [PATCH v2 08/14] block: Kill bi_destructor

On 05/24/2012 10:52 PM, Vivek Goyal wrote:

> In fact I am not even sure that for one driver we should introduce
> bio_reset() in generic block layer. So to me we should get rid of bio_reset()
> and let all the gory details remain in driver.
> 


I disagree. The kind of trick we do where up to BIO_RESET_BYTES
the struct is memset **must** stay at header, very close to the
structure.

I would though make bio_reset() inline at header, it's a single
memset. Even the memset is inlined by the compiler.

> Thanks
> Vivek


Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/