lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1338045703-17581-1-git-send-email-dabydeem@sheridanc.on.ca>
Date:	Sat, 26 May 2012 11:21:43 -0400
From:	Michael Dabydeen <dabydeem@...ridanc.on.ca>
To:	linux-kernel@...r.kernel.org
Cc:	Michael Dabydeen <dabydeem@...ridanc.on.ca>,
	Michael Dabydeen <mdabydeen@...il.com>
Subject: [PATCH] Staging: comedi: mpc82860: fixed a brace coding style issue

Fixed a coding style issue

Signed-off-by: Michael Dabydeen<mdabydeen@...il.com>
---
 drivers/staging/comedi/drivers/mpc8260cpm.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/mpc8260cpm.c b/drivers/staging/comedi/drivers/mpc8260cpm.c
index 364470e..6d291b7 100644
--- a/drivers/staging/comedi/drivers/mpc8260cpm.c
+++ b/drivers/staging/comedi/drivers/mpc8260cpm.c
@@ -36,7 +36,7 @@ It is apparently missing some code.
 
 #include "../comedidev.h"
 
-extern unsigned long mpc8260_dio_reserved[4];
+unsigned long mpc8260_dio_reserved[4];
 
 struct mpc8260cpm_private {
 
@@ -71,10 +71,8 @@ static int mpc8260cpm_dio_config(struct comedi_device *dev,
 
 	port = (int)s->private;
 	mask = 1 << CR_CHAN(insn->chanspec);
-	if (mask & cpm_reserved_bits[port]) {
+	if (mask & cpm_reserved_bits[port])
 		return -EINVAL;
-	}
-
 	switch (data[0]) {
 	case INSN_CONFIG_DIO_OUTPUT:
 		s->io_bits |= mask;
@@ -122,7 +120,7 @@ static int mpc8260cpm_attach(struct comedi_device *dev,
 	struct comedi_subdevice *s;
 	int i;
 
-	printk("comedi%d: mpc8260cpm: ", dev->minor);
+	printk(KERN_ERROR , "comedi%d: mpc8260cpm: ", dev->minor);
 
 	dev->board_ptr = mpc8260cpm_boards + dev->board;
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ