linux-kernel - Re: [PATCH] tty: remove recursive implementation of tty_ldisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVPh5W+a5hr4uVPZRP8GyEEFz86-FH5mp2R5=rCjgmcXAg@mail.gmail.com>
Date:	Sat, 26 May 2012 10:45:55 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	levinsasha928@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: remove recursive implementation of tty_ldisc_release

On Fri, May 25, 2012 at 7:11 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> From: Alan Cox <alan@...ux.intel.com>
>
> We need to do this in one pass with the locking requirements we now
> have.
>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
>
>  drivers/tty/tty_ldisc.c |   40 +++++++++++++++++++++++-----------------
>  1 files changed, 23 insertions(+), 17 deletions(-)
>
>
> diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
> index 833e851..ecfaef5 100644
> --- a/drivers/tty/tty_ldisc.c
> +++ b/drivers/tty/tty_ldisc.c
> @@ -894,6 +894,23 @@ int tty_ldisc_setup(struct tty_struct *tty, struct tty_struct *o_tty)
>        tty_ldisc_enable(tty);
>        return 0;
>  }
> +
> +static int tty_ldisc_kill(struct tty_struct *tty)

Maybe the return type should be defined as void to avoid compile warning.


After applying Alan's three patches for addressing tty locks and the patch
int the below link:

     http://marc.info/?l=linux-kernel&m=133775308420817&w=2

Looks no lockdep warnings are triggered any more when running
'exit' in shell of ssh session.

So I will send out the formal patch in the above link.

Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/