linux-kernel - Re: [PATCH] mmc: core: Fix build warning with !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMQu2gxH0e=Kdh5eABi3W07Rg_HNsCChUmNOtV4HmxYpQssmFA@mail.gmail.com>
Date:	Sun, 27 May 2012 16:11:55 +0530
From:	"Shilimkar, Santosh" <santosh.shilimkar@...com>
To:	Chris Ball <cjb@...top.org>
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: core: Fix build warning with !CONFIG_SUSPEND

On Sun, May 27, 2012 at 8:22 AM, Chris Ball <cjb@...top.org> wrote:
> Hi,
>
> On Sat, May 19 2012, Santosh Shilimkar wrote:
>> With !CONFIG_SUSPEND, mmc core layer throws below build warnings.
>>
>> drivers/mmc/core/bus.c:125: warning: 'mmc_bus_suspend' defined but not used
>> drivers/mmc/core/bus.c:136: warning: 'mmc_bus_resume' defined but not used
>> drivers/mmc/core/sdio_bus.c:197: warning: 'pm_no_operation' defined but not used
>>
>> Fix is by wrapping suspend hooks under CONFIG_SUSPEND
>>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@...com>
>> Cc: Chris Ball <cjb@...top.org>
>> ---
>>  drivers/mmc/core/bus.c      |    2 ++
>>  drivers/mmc/core/sdio_bus.c |    2 +-
>>  2 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
>> index c60cee9..ca8925d 100644
>> --- a/drivers/mmc/core/bus.c
>> +++ b/drivers/mmc/core/bus.c
>> @@ -122,6 +122,7 @@ static int mmc_bus_remove(struct device *dev)
>>       return 0;
>>  }
>>
>> +#ifdef CONFIG_SUSPEND
>>  static int mmc_bus_suspend(struct device *dev)
>>  {
>>       struct mmc_driver *drv = to_mmc_driver(dev->driver);
>> @@ -143,6 +144,7 @@ static int mmc_bus_resume(struct device *dev)
>>               ret = drv->resume(card);
>>       return ret;
>>  }
>> +#endif
>>
>>  #ifdef CONFIG_PM_RUNTIME
>>
>> diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c
>> index 236842e..87d1b7e 100644
>> --- a/drivers/mmc/core/sdio_bus.c
>> +++ b/drivers/mmc/core/sdio_bus.c
>> @@ -192,7 +192,7 @@ static int sdio_bus_remove(struct device *dev)
>>       return ret;
>>  }
>>
>> -#ifdef CONFIG_PM
>> +#ifdef CONFIG_SUSPEND
>>
>>  static int pm_no_operation(struct device *dev)
>>  {
>
> This patch doesn't apply against mmc-next, and I think this has already
> been fixed upstream -- please could you retest against Linus HEAD?
>
Indeed. It got fixed by commit 0dd1bfeb6.
Thanks for the update.

Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/