linux-kernel - Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2012 09:03:36 +0200
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	T Makphaibulchoke <tmac@...com>
Cc:	lethal@...ux-sh.org, hpa@...or.com, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, kaloz@...nwrt.org,
	matt.fleming@...el.com, lasse.collin@...aani.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
	linux@....linux.org.uk, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux390@...ibm.com
Subject: Re: [PATCH] lib/decompress_unxz.c: removing all memory helper
 functions

On 10:03 Thu 24 May     , T Makphaibulchoke wrote:
> The patch cleans up the file lib/decompress_unxz.c by removing all memory
> helper functions, e.g., memmove.  By doing so, any architecture's preboot
> environment supporting the XZ decompression needs to define its own copy of
> any of the missing memory helper functions.
> 
> The patch makes sure that all 4 architectures' preboot currently supporting
> the XZ decompressor, arm, s390, sh and x86, build without error when using
> the XZ compression.
> 
> Adding a prototype for the memcmp function required by the XZ decompressor to
> workaround compiler's implicit type error.  Also removing both the memmove and
> memcpy defines workaround, to disable lib/decompress_unxz.c from duplicating
> both functions.
> 
> Adding the missing memcmp function, required by the XZ decompressor, to the
> s390 preboot environment.
> 
> Adding both the missing memmove and memcmp functions, required by the XZ
> decompressor, to the sh preboot environment.
> 
> Adding the missing memmove function, required by XZ decompressor, to the x86
> preboot environment.
> 
> Signed-off-by: T. Makphaibulchoke <tmac@...com>
> ---
>  arch/arm/boot/compressed/decompress.c |    3 +-
>  arch/s390/boot/compressed/misc.c      |   14 +++++
>  arch/sh/boot/compressed/misc.c        |   32 ++++++++++++
>  arch/x86/boot/compressed/string.c     |   18 +++++++a
can we do not duplicate those functions?

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/