linux-kernel - [PATCH] fbdev: make FIRMWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2012 17:04:15 +0800
From:	Eric Miao <eric.miao@...onical.com>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Eric Miao <eric.miao@...onical.com>
Subject: [PATCH] fbdev: make FIRMWARE_EDID depends on X86

The only place where CONFIG_FIRMWARE_EDID is used is in fbmon.c,
and only when CONFIG_X86 is defined, this implied dependency will
be better specified in Kconfig.  Otherwise, CONFIG_FIRMWARE_EDID
can be turned on pointlessly for other architectures, and causing
a bit confusion when doing configs across different architectures.

Signed-off-by: Eric Miao <eric.miao@...onical.com>
---
 drivers/video/Kconfig |    2 +-
 drivers/video/fbmon.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index a290be5..61af035 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -69,7 +69,7 @@ menuconfig FB
 
 config FIRMWARE_EDID
        bool "Enable firmware EDID"
-       depends on FB
+       depends on FB && X86
        default n
        ---help---
          This enables access to the EDID transferred from the firmware.
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
index cef6557..e8ada4d 100644
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -1458,7 +1458,7 @@ int fb_validate_mode(const struct fb_var_screeninfo *var, struct fb_info *info)
 		-EINVAL : 0;
 }
 
-#if defined(CONFIG_FIRMWARE_EDID) && defined(CONFIG_X86)
+#ifdef CONFIG_FIRMWARE_EDID
 
 /*
  * We need to ensure that the EDID block is only returned for
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/