linux-kernel - Re: [PATCH] [staging] bcm: Fix codingstyle problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1338172734.977.3.camel@joe2Laptop>
Date:	Sun, 27 May 2012 19:38:54 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kevin McKinney <klmckinney1@...il.com>
Cc:	Devendra Naga <devendra.aaru@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [staging] bcm: Fix codingstyle problems

On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote:
> Hi Devendra,
> 
> On Sun, May 27, 2012 at 4:54 PM, Devendra Naga <devendra.aaru@...il.com> wrote:
> > Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
> > ---
> >  drivers/staging/bcm/Debug.h |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> I understand this is a simple change, but please add a descriptive
> change log to your patch for consistency.

Hello as well.

Devendra, sometimes the simpler change isn't the best change.
Consider converting some of these macros into functions.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/