linux-kernel - Re: [PATCH 12/13] backlight: tosa_bl: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120528124831.GA18592@sirena.org.uk>
Date:	Mon, 28 May 2012 13:48:31 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
Cc:	Jingoo Han <jg1.han@...sung.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH 12/13] backlight: tosa_bl: use devm_ functions

On Sat, May 26, 2012 at 10:43:07AM +0400, Dmitry Eremin-Solenikov wrote:
> On Fri, May 25, 2012 at 6:30 AM, Jingoo Han <jg1.han@...sung.com> wrote:

> > The devm_ functions allocate memory that is released when a driver
> > detaches. This patch uses devm_kzalloc of these functions.

> Strictly speaking I see no point in this changes. There are no
> 'missing free' problems
> in these drivers, the code path is clean enough. Is devm_kzalloc usage some kind
> of policy, or it is just a future-proof change?

It does provide robustness against future changes and it's also the more
current style; if nothing else it helps anyone who wants to go and audit
for leaks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/