linux-kernel - Re: [PATCH] perf record: fix branch_stack type in perf_record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2012 20:40:42 +0530
From:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To:	Stephane Eranian <eranian@...gle.com>
CC:	linux-kernel@...r.kernel.org, acme@...hat.com,
	peterz@...radead.org, mingo@...e.hu
Subject: Re: [PATCH] perf record: fix branch_stack type in perf_record_opts

On Saturday 26 May 2012 02:43 AM, Stephane Eranian wrote:

> 
> The attr.branch_sample_type field is defined as u64 by the API.
> As such, we need to ensure the variable holding the value of the
> branch stack filters is also u64 otherwise we may lose bits in
> the future.
> 
> Note also that the bogus definition of the field in
> perf_record_opts caused problems on big-endian PPC systems.
> Thanks to Anshuman Khandual for tracking the problem on PPC.
> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>


Acked-by: Anshuman Khandual <khandual@...ux.vnet.ibm.com>

> ---
> 
> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index 14f1034..f960ccb 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -227,7 +227,7 @@ struct perf_record_opts {
>  	unsigned int freq;
>  	unsigned int mmap_pages;
>  	unsigned int user_freq;
> -	int	     branch_stack;
> +	u64          branch_stack;
>  	u64	     default_interval;
>  	u64	     user_interval;
>  };
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/