lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 May 2012 12:12:23 -0400 (EDT) From: Mikulas Patocka <mpatocka@...hat.com> To: Kent Overstreet <koverstreet@...gle.com> cc: linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org, dm-devel@...hat.com, linux-fsdevel@...r.kernel.org, tj@...nel.org, axboe@...nel.dk, agk@...hat.com, neilb@...e.de, drbd-dev@...ts.linbit.com, bharrosh@...asas.com, vgoyal@...hat.com, sage@...dream.net, yehuda@...newdream.net Subject: Re: [PATCH v3 08/16] block: Rework bio splitting On Fri, 25 May 2012, Kent Overstreet wrote: > diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c > index f8b6f14..0062326 100644 > --- a/drivers/md/raid10.c > +++ b/drivers/md/raid10.c > @@ -1001,15 +1001,9 @@ static void make_request(struct mddev *mddev, struct bio * bio) > > chunk_sects && > conf->near_copies < conf->raid_disks)) { > struct bio_pair *bp; > - /* Sanity check -- queue functions should prevent this happening */ > - if (bio->bi_vcnt != 1 || > - bio->bi_idx != 0) > - goto bad_map; > - /* This is a one page bio that upper layers > - * refuse to split for us, so we need to split it. > - */ > + That "Sanity check" should be removed from drivers/md/raid0.c too. Your patch only removes it from raid10. Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists