linux-kernel - Re: [PATCH 1/2] Allow constructor name selection by architecture.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120528203005.GA20560@merkur.ravnborg.org>
Date:	Mon, 28 May 2012 22:30:05 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Vincent Sanders <vincent.sanders@...labora.co.uk>
Cc:	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Vincent Sanders <vince@...labora.co.uk>
Subject: Re: [PATCH 1/2] Allow constructor name selection by architecture.

On Mon, May 28, 2012 at 07:33:37PM +0100, Vincent Sanders wrote:
> From: Vincent Sanders <vince@...labora.co.uk>
> 
> The constructor symbol name is different between platforms. Allow this
> to be selected by configuration and set suitable default values.
> 
> Signed-off-by: Vincent Sanders <vincent.sanders@...labora.co.uk>
> ---
>  include/asm-generic/vmlinux.lds.h |    6 +++---
>  init/Kconfig                      |    6 ++++++
>  kernel/module.c                   |    2 +-
>  3 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 8aeadf6..fd34808 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -471,9 +471,9 @@
>  	}
>  
>  #ifdef CONFIG_CONSTRUCTORS
> -#define KERNEL_CTORS()	. = ALIGN(8);			   \
> -			VMLINUX_SYMBOL(__ctors_start) = .; \
> -			*(.ctors)			   \
> +#define KERNEL_CTORS()	. = ALIGN(8);					\
> +			VMLINUX_SYMBOL(__ctors_start) = .;		\
> +			*(CONFIG_CONSTRUCTORS_NAME)			\
>  			VMLINUX_SYMBOL(__ctors_end) = .;

What is wrong with adding both "standard" names for ctors uncnditionally?
Like this:
> 			*(.ctors)			   \
> +			*(.init_array)			   \


	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/