linux-kernel - Re: [PATCH] leds: don't disable blinking when writing the same value to delay_on or delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK5ve-+ZjD-QW-JipX_w67pZHU0NkSKrMgVhWBAeEuf5Zk2dww@mail.gmail.com>
Date:	Tue, 29 May 2012 09:52:34 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	Rafal Prylowski <prylowski@...asoft.pl>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] leds: don't disable blinking when writing the same value
 to delay_on or delay_off

On Mon, May 28, 2012 at 11:35 PM, Rafal Prylowski <prylowski@...asoft.pl> wrote:
> Function led_set_software_blink() assumes that blink timer is still running,
> but commit 488bc35bf40df89d37486c1826b178a2fba36ce7 introduced disabling
> of blink timer before each call to led_set_software_blink().
>
> Correct led_software_blink():
> 1) remove protection against reprogramming blink timer to the same values,
>   because it only disables blinking now,
> 2) remove unnecessary call to led_stop_software_blink().
>

Fair enough. Applied to my fixed-for-3.5 branch.

Thanks,
-Bryan

> Signed-off-by: Rafal Prylowski <prylowski@...asoft.pl>
> Cc: Bryan Wu <bryan.wu@...onical.com>
> Cc: Richard Purdie <rpurdie@...ys.net>
> ---
>
> Patch applies to current mainline.
>
>  drivers/leds/led-core.c |    7 -------
>  1 file changed, 7 deletions(-)
>
> Index: mainline/drivers/leds/led-core.c
> ===================================================================
> --- mainline.orig/drivers/leds/led-core.c
> +++ mainline/drivers/leds/led-core.c
> @@ -44,13 +44,6 @@ static void led_set_software_blink(struc
>        if (!led_cdev->blink_brightness)
>                led_cdev->blink_brightness = led_cdev->max_brightness;
>
> -       if (led_get_trigger_data(led_cdev) &&
> -           delay_on == led_cdev->blink_delay_on &&
> -           delay_off == led_cdev->blink_delay_off)
> -               return;
> -
> -       led_stop_software_blink(led_cdev);
> -
>        led_cdev->blink_delay_on = delay_on;
>        led_cdev->blink_delay_off = delay_off;
>



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/