linux-kernel - Re: [PATCH V2] [staging] bcm: Replace the BCM_DEBUG_* and BCM_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHdPZaOkFa-=boq6eXVZUyhGN80TXg+iWoE7sQKbnyxBjej44A@mail.gmail.com>
Date:	Tue, 29 May 2012 15:45:14 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] [staging] bcm: Replace the BCM_DEBUG_* and BCM_SHOW_*
 macros with functions

Hello Eric,

On Tue, May 29, 2012 at 3:36 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2012-05-29 at 15:21 +0530, Devendra Naga wrote:
>> This patch is made by following the improvements told by Joe Perches,
>> replaced the BCM_DEBUG* and BCM_SHOW* macros into functions and added them
>> in a file and added macros in the Debug.h file. This patch also improves the if
>> check in bcm_show_debug_bitmap,
>>
>> the check was
>>       if ((i == 1) || (i == 2) || (i == 4) || (i == 8));
>> anyway its a check to find whether its a power of two, and replaces
>> it like the following,
>>       if ((i != 0) && !(i & (i - 1)))
>
> So why not using is_power_of_2() ?
>
I really dont know its there. Thanks for letting me know, :), will do
and submit the change.
>

Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/